Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

write catalog now writes relative paths per default #483

Merged
merged 6 commits into from
Oct 5, 2022
Merged

write catalog now writes relative paths per default #483

merged 6 commits into from
Oct 5, 2022

Conversation

francescalb
Copy link
Collaborator

It is now possible to choose to write abslute paths when writing catalog, but relative paths to current folder are default.

Description:

Type of change:

  • Bug fix.
  • New feature.
  • Documentation update.

Checklist:

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments:

@francescalb francescalb linked an issue Oct 4, 2022 that may be closed by this pull request
Give option to write_catalog for writing relative paths #473
Closed
jesper-friis
jesper-friis reviewed Oct 4, 2022
View reviewed changes
ontopy/utils.py Outdated Show resolved Hide resolved
jesper-friis
jesper-friis reviewed Oct 4, 2022
View reviewed changes
ontopy/utils.py Outdated Show resolved Hide resolved
jesper-friis
jesper-friis reviewed Oct 4, 2022
View reviewed changes
tests/test_catalog.py Outdated Show resolved Hide resolved
jesper-friis
jesper-friis reviewed Oct 4, 2022
View reviewed changes
Copy link
Collaborator

@jesper-friis jesper-friis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but haven't tested it... Take a look at the comments and apply those that make sense.

francescalb and others added 3 commits October 5, 2022 07:12
@francescalb @jesper-friis
print statement removed
548222b 
Co-authored-by: Jesper Friis <jesper-friis@users.noreply.github.com>
@francescalb
Removed resetting of mappings key when not changed
0c28069
@francescalb
Merge branch '473-give-option-to-write_catalog-for-writing-relative-p…
91e6717 
…aths' of github.com:emmo-repo/EMMOntoPy into 473-give-option-to-write_catalog-for-writing-relative-paths
@francescalb francescalb merged commit ae1d33a into master Oct 5, 2022
@francescalb francescalb deleted the 473-give-option-to-write_catalog-for-writing-relative-paths branch October 5, 2022 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jesper-friis jesper-friis jesper-friis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Give option to write_catalog for writing relative paths
2 participants
@francescalb @jesper-friis